fetch port number of the running container and port on the host#87
fetch port number of the running container and port on the host#87mramanathan wants to merge 4 commits intojenkinsci:masterfrom
Conversation
|
Not sure who reviews PRs in this GH repo. Could the concerned person evaluate this PR ? |
| stage('prep') { | ||
| steps { | ||
| script { | ||
| env.GIT_HASH = sh( |
There was a problem hiding this comment.
Is this GIT_HASH environment variable required by the script? I cannot see where it is dereferenced.
| steps { | ||
| script { | ||
| env.GIT_HASH = sh( | ||
| script: "git show --oneline | head -1 | cut -d' ' -f1", |
There was a problem hiding this comment.
You can get the latest commit hash by a pure git command: git rev-parse HEAD. The result will be the same.
|
@goostleek : Thanks for your time, I have cleaned 'prep' stage that gathers SHA-1 id of Git commit. Hope it's good to go now. |
|
@mramanathan Looks good to me. However, I'm not the maintainer of the repo. I'm just a casual wanderer that came across your PR because I starred the repo to look for the new examples as they appear :) |
|
@goostleek No probs, will wait for the maintainers' action. |
|
There's a bunch of stuff here that's unnecessary for a Pipeline snippet (timestamps, cleanWs). That should probably be limited to |
|
a076ca4 looks unrelated. I recommend you don't submit PRs from a master branch. |
|
@daniel-beck Agreed, I have trimmed the code and updated the PR with new commit, 704057f |
|
@mramanathan All of that is still there: https://github.com/jenkinsci/pipeline-examples/pull/87/files Even if you delete the file it will clog up the history unless you rewrite Git history. |
|
@daniel-beck Hopefully it's better now, with rewritten Git history. |
3 participants
Reference image used, https://hub.docker.com/r/tutum/hello-world/
This pipeline code snippet will (though Dockerfile is not supported which is two lines of code) fetch tutum/hello-world image, build it, start a new container based on it at port 80, will fetch host port that maps to the port of the running container, and run curl on the port of the localhost to check HTTP response.